Commit 28f39cda authored by Sebastian Kummer's avatar Sebastian Kummer

ZP-250 Removed echo line, clearified TODO, removed other TODO.

Released under the Affero GNU General Public License (AGPL) version 3.
parent 14bd2d83
...@@ -865,7 +865,8 @@ class ASDevice extends StateObject { ...@@ -865,7 +865,8 @@ class ASDevice extends StateObject {
// check if a folder with that Name is already in the list and that its parent exists // check if a folder with that Name is already in the list and that its parent exists
$parentFound = false; $parentFound = false;
foreach ($this->additionalfolders as $k => $folder) { foreach ($this->additionalfolders as $k => $folder) {
// TODO: this parentid check should go into fixstates! // This is fixed in fixstates, but we could keep this here a while longer.
// TODO: remove line at a later point.
if (!isset($folder['parentid'])) $folder['parentid'] = "0"; if (!isset($folder['parentid'])) $folder['parentid'] = "0";
if ($folder['name'] == $name && $folder['parentid'] == $parentid) { if ($folder['name'] == $name && $folder['parentid'] == $parentid) {
...@@ -1087,7 +1088,6 @@ class ASDevice extends StateObject { ...@@ -1087,7 +1088,6 @@ class ASDevice extends StateObject {
foreach($toOrderFolders as $folder) { foreach($toOrderFolders as $folder) {
// move folders with the matching parentid to the ordered array // move folders with the matching parentid to the ordered array
if ($folder['parentid'] == $parentid) { if ($folder['parentid'] == $parentid) {
echo "found.. \n";
$fid = $folder['folderid']; $fid = $folder['folderid'];
$orderedFolders[$fid] = $folder; $orderedFolders[$fid] = $folder;
unset($toOrderFolders[$fid]); unset($toOrderFolders[$fid]);
......
...@@ -484,7 +484,7 @@ class DeviceManager { ...@@ -484,7 +484,7 @@ class DeviceManager {
} }
if (!isset($df['parentid'])) { if (!isset($df['parentid'])) {
$df['parentid'] = '0'; $df['parentid'] = '0';
ZLog::Write(LOGLEVEL_WARN, sprintf("DeviceManager->GetAdditionalUserSyncFolders(): Additional folder '%s' has no parentid. // TODO FIX: Please run 'z-push-admin -a fixstates' to fix this issue.", $df['name'])); ZLog::Write(LOGLEVEL_WARN, sprintf("DeviceManager->GetAdditionalUserSyncFolders(): Additional folder '%s' has no parentid. Please run 'z-push-admin -a fixstates' to fix this issue.", $df['name']));
} }
$folder = $this->getAdditionalSyncFolderObject($df['store'], $df['folderid'], $df['parentid'], $df['name'], $df['type'], $df['flags'], DeviceManager::FLD_ORIGIN_SHARED); $folder = $this->getAdditionalSyncFolderObject($df['store'], $df['folderid'], $df['parentid'], $df['name'], $df['type'], $df['flags'], DeviceManager::FLD_ORIGIN_SHARED);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment