ZP-895 Always call GetBackendIdForFolderId for Outlook in

ImportMessageReadFlag. Move $folderOrigin check into DeviceManager.
Rename $folderType to $folderOrigin in GetFolderIdForBackendId in
DeviceManager.

Released under the Affero GNU General Public License (AGPL) version 3.

src/backend/zarafa/importer.php

@@ -479,9 +479,7 @@ class ImportChangesICS implements IImportChanges {
         }
         // yeah OL sucks - ZP-779
         else {
-            if (ctype_digit($fsk)) {
-                $fsk = ZPush::GetDeviceManager()->GetBackendIdForFolderId($fsk);
-            }
+            $fsk = ZPush::GetDeviceManager()->GetBackendIdForFolderId($fsk);
             $store = ZPush::GetBackend()->GetMAPIStoreForFolderId(ZPush::GetAdditionalSyncFolderStore($fsk), $fsk);
             $entryid = mapi_msgstore_entryidfromsourcekey($store, hex2bin($fsk), hex2bin($sk));
             $realMessage = mapi_msgstore_openentry($store, $entryid);

src/lib/core/asdevice.php

@@ -698,9 +698,6 @@ class ASDevice extends StateObject {
 
         // nothing found? Then it's a new one, get and add it
         if (is_array($this->backend2folderidCache) && $generateNewIdIfNew) {
-            if (!in_array($folderOrigin, array(DeviceManager::FLD_ORIGIN_CONFIG, DeviceManager::FLD_ORIGIN_GAB, DeviceManager::FLD_ORIGIN_SHARED, DeviceManager::FLD_ORIGIN_USER))) {
-                ZLog::Write(LOGLEVEL_WARN, sprintf("ASDevice->GetFolderIdForBackendId(): folder type '%' is unknown in DeviceManager", $folderOrigin));
-            }
             if ($folderName == null) {
                 ZLog::Write(LOGLEVEL_INFO, "ASDevice->GetFolderIdForBackendId(): generating a new folder id for the folder without a name");
             }

src/lib/core/devicemanager.php

@@ -884,7 +884,7 @@ class DeviceManager {
      *
      * @param string    $backendid              Backend folder id
      * @param boolean   $generateNewIdIfNew     Generates a new AS folderid for the case the backend folder is not known yet, default: false.
-     * @param string    $folderType             Folder type is one of   'U' (user)
+     * @param string    $folderOrigin           Folder type is one of   'U' (user)
      *                                                                  'C' (configured)
      *                                                                  'S' (shared)
      *                                                                  'G' (global address book)
@@ -893,8 +893,11 @@ class DeviceManager {
      * @access public
      * @return string/boolean  returns false if there is folderid known for this backendid and $generateNewIdIfNew is not set or false.
      */
-    public function GetFolderIdForBackendId($backendid, $generateNewIdIfNew = false, $folderType = self::FLD_ORIGIN_USER, $folderName = null) {
-        return $this->device->GetFolderIdForBackendId($backendid, $generateNewIdIfNew, $folderType, $folderName);
+    public function GetFolderIdForBackendId($backendid, $generateNewIdIfNew = false, $folderOrigin = self::FLD_ORIGIN_USER, $folderName = null) {
+        if (!in_array($folderOrigin, array(DeviceManager::FLD_ORIGIN_CONFIG, DeviceManager::FLD_ORIGIN_GAB, DeviceManager::FLD_ORIGIN_SHARED, DeviceManager::FLD_ORIGIN_USER))) {
+            ZLog::Write(LOGLEVEL_WARN, sprintf("ASDevice->GetFolderIdForBackendId(): folder type '%' is unknown in DeviceManager", $folderOrigin));
+        }
+        return $this->device->GetFolderIdForBackendId($backendid, $generateNewIdIfNew, $folderOrigin, $folderName);
     }